Checklists

requirements.md

Specification Quality Checklist: Decompose doctor.py God-Module (Residual)

Purpose: Validate specification completeness and quality before proceeding to planning Created: 2026-06-24 Feature: spec.md

Content Quality

  • ✅ No implementation details that overreach — file/symbol/cluster references are scoping context for a behavior-preserving dev refactor; requirements stay outcome-stated (byte-identical CLI, ≤15 CC, ≥90% cover)
  • ✅ Focused on value (de-godding maintainability without operator-visible change)
  • ✅ Written for stakeholders (overview + scenarios + plain success criteria)
  • ✅ All mandatory sections completed (Overview, Scenarios, FR, NFR, Constraints, Success, Key Entities, Assumptions, Research Outcomes)

Requirement Completeness

  • ✅ No [NEEDS CLARIFICATION] markers remain
  • ✅ Requirements are testable and unambiguous (golden harness, CC gate, coverage gate, re-export resolution, import-graph one-way)
  • ✅ Requirement types separated (FR / NFR / Constraint)
  • ✅ IDs unique across FR-###, NFR-###, C-###
  • ✅ All FR rows carry Status = Approved
  • ✅ Non-functional requirements carry measurable thresholds (CC ≤ 15; coverage ≥ 90%; zero new suppressions; byte-identical surface)
  • ✅ Success criteria measurable (SC-001..SC-007)
  • ✅ Success criteria outcome-stated (surface identical; gates clean; single Console; no cycle)
  • ✅ All acceptance scenarios defined (CLI unchanged, test re-imports, cross-module coupling, seam completion, mega-fn decomposition)
  • ✅ Edge cases identified (per-module Console regression, H2 hoist regression, oversized relocation, missing re-export, noqa rules)
  • ✅ Scope bounded (residual after #1623; do NOT re-extract MODEL/RENDER; _auth_doctor out of scope)
  • ✅ Dependencies and assumptions identified

Feature Readiness

  • ✅ All FRs have clear acceptance criteria (mapped to SC-001..SC-007 + WP01 golden harness)
  • ✅ User scenarios cover primary flows
  • ✅ Meets measurable outcomes in Success Criteria
  • ✅ HOW (exact sibling boundaries, helper splits) deferred to plan

Notes

  • This is a behavior-preserving refactor: the dominant acceptance proof is the WP01 golden CLI characterization harness (byte-identical pre/post). C-005 makes it land FIRST.
  • Two circular-import hazards (H1 shared console home; H2 function-local merge import) are explicit FR-007 acceptance gates.
  • Sibling/symbol/cluster references trace directly to research.md (§1–§6) and data-model.md (target topology + invariants I-1..I-8).