Spec Kitty

└─ kitty-specs
   └─ Reject Cyclic Lane Graphs

Mission Run:

📚 Docs ↗

Phase 1 Quickstart: Verification

Run commands from the repository root checkout on fix/reject-cyclic-lane-graphs.

Focused behavior

uv run pytest \
  tests/specify_cli/lanes/test_lane_dependency_cycle_detection.py \
  tests/specify_cli/lanes/test_compute_lane_depths_cycle_safety.py \
  tests/specify_cli/cli/commands/agent/test_finalize_lane_dependency_cycle.py \
  tests/specify_cli/lanes/test_lane_dependency_cycle_determinism.py \
  tests/specify_cli/lanes/test_lane_dependency_cycle_cli_determinism.py

The suite must demonstrate:

deterministic rejection of two-lane, three-lane, multiple, and planning-lane cycles;
the same structured details from mutating and --validate-only finalization;
no traceback or recursion failure;
absent lanes.json remains absent;
existing lanes.json remains byte-identical;
clean DAGs preserve existing results.

Determinism

Run the structured CLI fixture, which launches canonical finalize-tasks --validate-only --json subprocesses under seeds 1, 7, and 97 and compares the error_code, cycle_path, and cycle_lanes portions byte-for-byte:

uv run pytest tests/specify_cli/lanes/test_lane_dependency_cycle_cli_determinism.py -q

Performance

SPEC_KITTY_RUN_PERFORMANCE=1 uv run pytest \
  tests/specify_cli/lanes/test_lane_dependency_cycle_performance.py \
  -m performance -q

For the fixed 100-lane/500-edge fixture, the detector's p95 must be no more than 100 ms on the CI runner.

Quality gates

uv run ruff check \
  src/specify_cli/lanes/compute.py \
  src/specify_cli/cli/commands/agent/mission_finalize.py \
  tests/specify_cli/lanes \
  tests/specify_cli/cli/commands/agent/test_finalize_lane_dependency_cycle.py

uv run mypy --strict \
  src/specify_cli/lanes/models.py \
  src/specify_cli/lanes/compute.py \
  src/specify_cli/cli/commands/agent/mission_finalize.py

uv run pytest tests/lanes tests/specify_cli/lanes tests/specify_cli/cli/commands/agent -q

If a failure is demonstrably pre-existing, follow charter directive DIR-013 and file a GitHub issue containing the command, failure summary, and evidence that this mission did not introduce it before treating it as baseline.